[
https://issues.apache.org/jira/browse/NUTCH-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660069#action_12660069
]
Andrzej Bialecki commented on NUTCH-594:
-----------------------------------------
Issues to be addressed before committing:
* many public classes lack javadoc - this needs to be added, especially since
you are adding a new extension point. Please add the class-level, public and
protected methods javadoc.
* SimpleDateFormat is not thread-safe (I wish it were!), so this makes
*ResponseWriter-s also not thread-safe. I believe this should be fixed, because
servlets can be invoked from multiple threads.
* new configuration properties should be documented in nutch-default.xml and
they should be given sensible defaults.
* the patch adds SearchServlet to web.xml, so it should ensure also that at
least one ResponseWriter plugin is turned on in nutch-default.xml.
* minor nits: I'm not sure that we really need pretty-printing in
XMLResponseWriter - indenting takes space (-> bandwidth). There are 2 spurious
spaces in plugin/build.xml diffs.
> Serve Nutch search results in multiple formats including XML and JSON
> ---------------------------------------------------------------------
>
> Key: NUTCH-594
> URL: https://issues.apache.org/jira/browse/NUTCH-594
> Project: Nutch
> Issue Type: New Feature
> Environment: all
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Attachments: commons-beanutils-1.8.0.jar,
> commons-collections-3.2.1.jar, ezmorph-1.0.6.jar, json-lib-2.2.2-jdk15.jar,
> NUTCH-594-1-20071221.patch, NUTCH-594-3-20081229.patch,
> NUTCH-594-4-20081230.patch
>
>
> Allow search results to be served in XML, JSON, and other configurable
> formats. Right now there is an OpenSearch servlet that returns returns in
> RSS. I would like something that has more flexibility in terms of the XML
> being served and also supports other formats such as JSON or plain text.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
