Bugs item #988546, was opened at 2004-07-10 09:46
Message generated for change (Comment added) made by cutting
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=491356&aid=988546&group_id=59548
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Stefan Groschupf (joa23)
Assigned to: Nobody/Anonymous (nobody)
Summary: PluginSystem test fails until using multiple plugin folders
Initial Comment:
Since it is now possible to use multiple plugin folders it can happen
that the plugin repository had registered more then just the plugins
generated by the test. In this case the test fail since unexpected
values are returned by third party plugins.
The attached patch fix the problem.
Index: TestPluginSystem.java
=========================================
==========================
RCS file: /cvsroot/nutch/nutch/src/test/net/nutch/plugin/
TestPluginSystem.java,v
retrieving revision 1.2
diff -u -r1.2 TestPluginSystem.java
--- TestPluginSystem.java 26 May 2004 17:26:46 -0000
1.2
+++ TestPluginSystem.java 10 Jul 2004 16:46:07 -0000
@@ -54,12 +54,15 @@
PluginDescriptor[] descriptors = PluginRepository.getInstance()
.getPluginDescriptors();
int k = descriptors.length;
- assertEquals(fPluginCount, k);
+ assertTrue(fPluginCount <= k);
for (int i = 0; i < descriptors.length; i++) {
- PluginDescriptor descriptor = descriptors[i];
- assertEquals(1, descriptor.getExportedLibUrls().length);
- assertEquals(1, descriptor.getNotExportedLibUrls().length);
- }
+ PluginDescriptor descriptor = descriptors[i];
+ if (!
descriptor.getPluginId().startsWith("getPluginFolder()")) {
+ continue;
+ }
+ assertEquals(1, descriptor.getExportedLibUrls().length);
+ assertEquals(1,
descriptor.getNotExportedLibUrls().length);
+ }
}
/**
*
@@ -116,11 +119,15 @@
.getPluginDescriptors();
for (int i = 0; i < descriptors.length; i++) {
PluginDescriptor descriptor = descriptors[i];
+ if (!descriptor.getPluginId().startsWith("getPluginFolder()")) {
+ continue;
+ }
String value = descriptor.getResourceString("key",
Locale.UK);
assertEquals("value", value);
value = descriptor.getResourceString("key",
Locale.TRADITIONAL_CHINESE);
assertEquals("value", value);
+
}
}
/**
----------------------------------------------------------------------
>Comment By: Doug Cutting (cutting)
Date: 2004-07-10 13:30
Message:
Logged In: YES
user_id=21778
Okay, I've applied this patch.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=491356&aid=988546&group_id=59548
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
Nutch-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nutch-developers
