Bugs item #1077261, was opened at 2004-12-02 03:34 Message generated for change (Comment added) made by abial You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=491356&aid=1077261&group_id=59548
Category: tools Group: mainline Status: Open Resolution: None Priority: 5 Submitted By: Matt Kangas (mkangas) >Assigned to: Andrzej Bialecki (abial) Summary: [PATCH] UpdateDatabaseTool: make "pageXXX" methods protected Initial Comment: This patch changes four methods from private to protected: - pageContentsUnchanged(), - pageContentsChanged() - pageGone() - pageRetry() Rationale: updateForSegment() is public, but the methods it relies on to save state are private, and thus can't be overridden. This change allows for custom subclasses, e.g. to filter items from FetcherOutput before adding to the webdb. ---------------------------------------------------------------------- >Comment By: Andrzej Bialecki (abial) Date: 2005-01-19 15:15 Message: Logged In: YES user_id=32200 I'm a bit reluctant to allow overriding here. The reason these methods are private is that it's very easy to break the whole scoring and page-tracking process if you change them, so we should not encourage overriding. In my opinion it would be better to add a plugin hook somewhere around line 92. Then you could provide a plugin implementation that could change the details of the FetcherOutput (e.g. setFetcherStatus()) to indicate how the current entry should be processed. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=491356&aid=1077261&group_id=59548 ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Nutch-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nutch-developers
