On Jul 21, 2005, at 10:22 AM, Erik Hatcher wrote:


On Jul 21, 2005, at 9:21 AM, Jérôme Charron wrote:


For grins I tried to see if I had commit access to fix the
misspelling myself. Lo and behold I do! I hope I didn't step on any
toes by committing this - if so let me know and I'll be more patient
and submit patches. I'm a newbie to Nutch and definitely don't want
to step in to committing lightly and I'll keep them only at the minor
fix type of level if at all.



Erik,

I don't look inside the modifications you have commited, but do you have
replaced the misspelled method, or add a new one (and deprecate the
misspelled one).
Since, it is an API that can be used by code that is outside of the nutch
code, it is better to deprecate such methods.


Do you really feel it is necessary to use deprecation in a pre-1.0 version like this? I'd be happy to add back the old method signature and deprecate it, but it seems unnecessary at this stage.

Just to ensure this isn't an issue, I went ahead and added the old method name back and deprecated it. This should be removed in the 1.0 release, or perhaps another pre-1.0 release.

    Erik



-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click
_______________________________________________
Nutch-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nutch-developers

Reply via email to