Well, it was at least the best way we had seen, since NutchConfigured require to implement a constructor that in most cases was unused as well, since most classes are instantiated class.newInstance().
So both solutions was optimal, and we decide for the interface solution.
I'm pretty sure this step can only be the beginning of working with non static configurations and there is a lot space for improvements.

Stefan

Am 31.01.2006 um 19:30 schrieb Sami Siren:

Andrzej Bialecki (JIRA) wrote:
[ http://issues.apache.org/jira/browse/NUTCH-169? page=comments#action_12364544 ] Andrzej Bialecki commented on NUTCH-169:
-----------------------------------------
This patch looks good! If there are no further objections, I'll test it and commit it within the next 12 hours.
I quess I am a bit late with this...

The goal of these changes is very good but I don't like the idea of duplicating identical code (implementing the interface NutchConfigure) instead of inheritance (extending NutchConfigured) in so many places.

--
 Sami Siren




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Nutch-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nutch-developers

Reply via email to