Stefan Groschupf wrote:
>modulo some minor whitespace changes.
Ok, I'm seriously interested in understanding the whitespace policy of
nutch. :-)
First I had used sun's java formating conventions, tabs to 4 spaces.
After negative feedback I used now sun's java conventions but using 2
spaces for one tab since I had seen this had been used in several
classes.
Please give me some rules and I will add these to the wiki and may
create a public eclipse/check style formating policy setup to solve
this problem than for ever.
I believe the policy was the same all the time since the beginning of
the project, it was just not strictly enforced... namely, to use the Sun
coding style with 2 literal spaces as a primary indent, 4 literal spaces
for secondary indent.
My comment was provoked by the following lines in your patch, which
violate this standard:
249-261, 271, 278, 290, 384 (this is a superfluous semicolon).
Oh, BTW: if you wonder why I'm so strict on this issue... I've been both
a member and a manager on many teams, with members coming with different
personal styles. I've been coding to this standard for many years, and
most of the time using vi ... in some situations you can't use IDE, the
best you can get is perhaps a vt100 terminal. I learned to appreciate
well-formatted code. And automatic reformatting in IDEs is not the
answer - most of the time it reformats too much, so that the diffs
between revisions become unreadable. So, it's better to be strict from
the start, and limit the suffering later ...
--
Best regards,
Andrzej Bialecki <><
___. ___ ___ ___ _ _ __________________________________
[__ || __|__/|__||\/| Information Retrieval, Semantic Web
___|||__|| \| || | Embedded Unix, System Integration
http://www.sigram.com Contact: info at sigram dot com
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Nutch-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nutch-developers
