[ https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505456 ]
Doğacan Güney commented on NUTCH-485: ------------------------------------- If no one has any objections, I want to commit this one. However, I have a question about patches. Latest patch has a couple of places where it removes an empty line (without adding anything else), or removes an empty line and adds another empty line (because of indentations). What is the policy on these? Personally, I think these are OK, but I would like to know what others think. > Change HtmlParseFilter 's to return ParseResult object instead of Parse object > ------------------------------------------------------------------------------ > > Key: NUTCH-485 > URL: https://issues.apache.org/jira/browse/NUTCH-485 > Project: Nutch > Issue Type: Improvement > Components: fetcher > Affects Versions: 1.0.0 > Environment: All > Reporter: Gal Nitzan > Fix For: 1.0.0 > > Attachments: NUTCH-485.200705122151.patch, > NUTCH-485.200705130928.patch, NUTCH-485.200705130945.patch, > NUTCH-485.200705131241.patch, NUTCH-485.200705140001.patch > > > The current implementation of HtmlParseFilters.java doesn't allow a filter to > add parse objects to the ParseResult object. > A change to the HtmlParseFilter is needed which allows the filter to return > ParseResult . and ofcourse a change to HtmlParseFilters . -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Nutch-developers mailing list Nutch-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nutch-developers