Tomi N/A wrote:
2007/4/19, qi wu <[EMAIL PROTECTED]>:
I am using Fetcher2, pls. refer the code fragment below:
if (newUrl != null && !newUrl.equals(fit.url.toString())) {
...
I'd have to take a look at the surrounding code to really understand
what the code does. I'm sure it's perfectly obvious to the authors and
they can't understand what's not to understand, though. :)
:) That's a good one ... In plain English: the page is trying to
redirect us to a new url. If the new url is present, and passed the
filters/normalizers, and it's different from the current url, consider
fetching it.
And I agree that the current code is ignorant of the setting of
db.ignore.external.links. The question however is whether we should
pollute this already complex code with additional checks for every
possible option ... This smells like a code that requires refactoring,
IMHO the decisions about such things should be fatored out and
encapsulated in a utility class.
This is more work than just adding a single line check, which may
suggest why it hasn't been done yet. Patches are welcome ;)
--
Best regards,
Andrzej Bialecki <><
___. ___ ___ ___ _ _ __________________________________
[__ || __|__/|__||\/| Information Retrieval, Semantic Web
___|||__|| \| || | Embedded Unix, System Integration
http://www.sigram.com Contact: info at sigram dot com
