[switching to the new mailing list]
On Mon, 2021-05-17 at 08:14 +0900, QI Fuli wrote:
> From: QI Fuli <[email protected]>
>
> This patch set is to rename monitor.conf to ndctl.conf, and make it a
> global ndctl configuration file that all ndctl commands can refer to.
>
> As this patch set has been pending until now, I would like to know if
> current idea works or not. If yes, I will finish the documents and test.
>
> Signed-off-by: QI Fuli <[email protected]>
Hi Qi,
Thanks for picking up on this! The approach generally looks good to me,
I think we can definitely move forward with this direction.
One thing that stands out is - I don't think we can simply rename the
existing monitor.conf. We have to keep supporting the 'legacy'
monitor.conf so that we don't break any deployments. I'd suggest
keeping the old monitor.conf as is, and continuing to parse it as is,
but also adding a new ndctl.conf as you have done.
We can indicate that 'monitor.conf' is legacy, and any new features
will only get added to the new global config to encourage migration to
the new config. Perhaps we can even provide a helper script to migrate
the old config to new - but I think it needs to be a user triggered
action.
This is timely as I also need to go add some config related
functionality to daxctl, and basing it on this would be perfect, so I'd
love to get this series merged in soon.
Thanks again!
-Vishal
>
> QI Fuli (3):
> ndctl, ccan: import ciniparser
> ndctl, util: add parse-configs helper
> ndctl, rename monitor.conf to ndctl.conf
>
> Makefile.am | 8 +-
> ccan/ciniparser/ciniparser.c | 480 +++++++++++++++++++++++++++++
> ccan/ciniparser/ciniparser.h | 262 ++++++++++++++++
> ccan/ciniparser/dictionary.c | 266 ++++++++++++++++
> ccan/ciniparser/dictionary.h | 166 ++++++++++
> configure.ac | 8 +-
> ndctl/Makefile.am | 9 +-
> ndctl/monitor.c | 127 ++------
> ndctl/{monitor.conf => ndctl.conf} | 16 +-
> util/parse-configs.c | 47 +++
> util/parse-configs.h | 26 ++
> 11 files changed, 1294 insertions(+), 121 deletions(-)
> create mode 100644 ccan/ciniparser/ciniparser.c
> create mode 100644 ccan/ciniparser/ciniparser.h
> create mode 100644 ccan/ciniparser/dictionary.c
> create mode 100644 ccan/ciniparser/dictionary.h
> rename ndctl/{monitor.conf => ndctl.conf} (82%)
> create mode 100644 util/parse-configs.c
> create mode 100644 util/parse-configs.h
>
