Use DEVICE_ATTR_ADMIN_RO() helper macro instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read.
Signed-off-by: Zhen Lei <[email protected]> --- drivers/dax/bus.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 5aee26e1bbd6dba..a8a26398a313cd9 100644 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -655,7 +655,7 @@ static ssize_t start_show(struct device *dev, return rc; } -static DEVICE_ATTR(start, 0400, start_show, NULL); +static DEVICE_ATTR_ADMIN_RO(start); static ssize_t end_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -671,9 +671,9 @@ static ssize_t end_show(struct device *dev, return rc; } -static DEVICE_ATTR(end, 0400, end_show, NULL); +static DEVICE_ATTR_ADMIN_RO(end); -static ssize_t pgoff_show(struct device *dev, +static ssize_t page_offset_show(struct device *dev, struct device_attribute *attr, char *buf) { struct dev_dax_range *dax_range; @@ -687,7 +687,7 @@ static ssize_t pgoff_show(struct device *dev, return rc; } -static DEVICE_ATTR(page_offset, 0400, pgoff_show, NULL); +static DEVICE_ATTR_ADMIN_RO(page_offset); static struct attribute *dax_mapping_attributes[] = { &dev_attr_start.attr, @@ -1191,7 +1191,7 @@ static ssize_t resource_show(struct device *dev, return sprintf(buf, "%#llx\n", start); } -static DEVICE_ATTR(resource, 0400, resource_show, NULL); +static DEVICE_ATTR_ADMIN_RO(resource); static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, char *buf) -- 2.26.0.106.g9fadedd
