Jeff had posted one patch to fix similar issue https://lore.kernel.org/linux-nvdimm/[email protected]/T/#u
Hi Dan/Visha Could we make some progress on this issue? On Thu, Jul 8, 2021 at 6:41 PM Aneesh Kumar K.V <[email protected]> wrote: > > With only seed namespace present, ndctl results in confusing error messages as > below. > > ndctl# ./ndctl/ndctl enable-namespace all > error enabling namespaces: No such device or address > enabled 0 namespaces > > ndctl# ./ndctl/ndctl disable-namespace all > disabled 3 namespaces > > ndctl# ./ndctl/ndctl destroy-namespace all -f > Error: destroy namespace: namespace1.0 failed to enable for zeroing, > continuing > > Error: destroy namespace: namespace1.1 failed to enable for zeroing, > continuing > > Error: destroy namespace: namespace0.0 failed to enable for zeroing, > continuing > > destroyed 0 namespaces > ndctl# > > With the patch we get > ndctl# ./ndctl/ndctl disable-namespace all > disabled 0 namespaces > > ndctl# ./ndctl/ndctl enable-namespace all > enabled 0 namespaces > > ndctl# ./ndctl/ndctl destroy-namespace all -f > destroyed 0 namespaces > ndctl# > > Signed-off-by: Aneesh Kumar K.V <[email protected]> > --- > ndctl/namespace.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/ndctl/namespace.c b/ndctl/namespace.c > index 0c8df9fa8b47..c52daeae562a 100644 > --- a/ndctl/namespace.c > +++ b/ndctl/namespace.c > @@ -2205,8 +2205,15 @@ static int do_xaction_namespace(const char *namespace, > return rc; > } > ndctl_namespace_foreach_safe(region, ndns, _n) { > - ndns_name = ndctl_namespace_get_devname(ndns); > > + if (!strcmp(namespace, "all") > + && > !ndctl_namespace_get_size(ndns)) { > + if (!*processed && rc) > + rc = 0; > + continue; > + } > + > + ndns_name = ndctl_namespace_get_devname(ndns); > if (strcmp(namespace, "all") != 0 > && strcmp(namespace, > ndns_name) != 0) > continue; > -- > 2.31.1 > > -- Best Regards, Yi Zhang
