On Tue, 2021-12-07 at 10:24 -0800, Dan Williams wrote: > On Mon, Dec 6, 2021 at 2:28 PM Vishal Verma <[email protected]> wrote: > > > > From: QI Fuli <[email protected]> > > > > Add iniparser[1] helper for parsing ndctl global configuration files. > > [1] https://github.com/ndevilla/iniparser > > Is there a reason this is being copied rather than linked? The ccan > code was copied because no distribution packaged it up into library > form, but iniparser ships in Fedora and Ubuntu. Unless ndctl needs to > maintain a fork I would prefer to link just like json-c is linked. > Even if ndctl needs a fork I would expect that to be called out here > with a plan to eventually get that forked feature into the upstream > iniparser project.
Ah I didn't realize it was packaged. I don't think we needed any changes to the core package - I'll change it to a linked dependency and remove the fork.
