Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Patch submitted to the wrong repository: adds `ndctl` userspace test files to the kernel tree. --
commit a640ffeb53f9a730f09dcd04ab6a813beaced234 Author: Richard Cheng <[email protected]> test/cxl-mbox: Regression test for huge CXL_MEM_SEND_COMMAND out.size This patch introduces a regression test for an unbounded kvzalloc() in cxl_mbox_cmd_ctor(). It creates a raw struct cxl_send_command and issues the ioctl directly against the cxl_test mock memdev. Link: https://lore.kernel.org/all/[email protected]/ > diff --git a/test/cxl-mbox.c b/test/cxl-mbox.c > new file mode 100644 > index 0000000000000..d81327ba17df4 > --- /dev/null > +++ b/test/cxl-mbox.c > @@ -0,0 +1,129 @@ [ ... ] > +#include <string.h> > +#include <unistd.h> > +#include <sys/ioctl.h> > +#include <cxl/libcxl.h> [Severity: Low] Was this patch intended for the ndctl repository instead of the Linux kernel tree? This includes an ndctl userspace library header that does not exist in the kernel tree. > +#include <cxl/cxl_mem.h> > + > +static const char provider[] = "cxl_test"; [ ... ] > diff --git a/test/cxl-mbox.sh b/test/cxl-mbox.sh > new file mode 100755 > index 0000000000000..67fecf5a3f46f > --- /dev/null > +++ b/test/cxl-mbox.sh > @@ -0,0 +1,48 @@ > +#!/bin/bash -Ex > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (C) 2026 Nvidia Corporation. All rights reserved. > + > +. $(dirname "$0")/common [Severity: Low] Does this code rely on an ndctl test dependency script that is absent from the kernel tree? It looks like both this script and the C file above are userspace tests belonging to the ndctl project rather than the kernel. > + > +BIN="$TEST_PATH"/cxl-mbox > +rc=77 [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
