On 11/6/26 18:05, Konstantin Khorenko wrote: > copy_huge_pud() adds the child's rmap of a device DAX PUD with > folio_add_file_rmap_pud(). That helper maps a folio afresh: it updates > NR_FILE_MAPPED when the folio becomes mapped and mlocks it in a > VM_LOCKED VMA. Neither applies at fork: the parent keeps the folio mapped > under the page table lock, and dup_mmap() clears VM_LOCKED in the > child's VMA. > > copy_present_ptes() duplicates the rmap of a PTE with > folio_dup_file_rmap_ptes(), which only raises the mapcounts. Add > folio_dup_file_rmap_pud() for the PUD level and use it in copy_huge_pud(). > > No functional change. > > Reviewed-by: David Hildenbrand (Arm) <[email protected]> > Reviewed-by: Zi Yan <[email protected]> > Signed-off-by: Konstantin Khorenko <[email protected]> > --- > David's fix for the device DAX PUD fork bug, commit d90bdc02e36e > ("mm/huge_memory: properly handle refcounted PUD mappings on fork"), > went in before v2 of my series for the same bug [1]. > > This is the follow-up David asked for [2]. > > The Reviewed-by tags are from v2 patch 1, whose rmap.h hunk and > copy_huge_pud() line this patch carries unchanged. > > The selftest from v2 [3] is not included, as it needs a real devdax > device. It is there for anyone who wants to run it. > > Based on thp-7.5.misc of the mm/core tree. > > [1] > https://lore.kernel.org/all/20261105-vstor-150143-copy_huge_pud-folio-refcount-v2-0-2828fe5a5...@virtuozzo.com/ > [2] > https://lore.kernel.org/all/[email protected]/ > [3] > https://lore.kernel.org/all/20261105-vstor-150143-copy_huge_pud-folio-refcount-v2-2-2828fe5a5...@virtuozzo.com/ > > Assisted-by: LLM > ---
Reviewed-by: David Hildenbrand (Arm) <[email protected]> Thanks, I'll wait a bit and then pick this up. -- Cheers, David
