On 11/6/26 18:41, Christoph Hellwig wrote:
> On Thu, Nov 05, 2026 at 02:58:42PM +0800, Mengmeng Zhao wrote:
>> + /* a dma-buf bio has no pages for integrity work or contents crypto */
>> if (unlikely(op_is_dmabuf(bio->bi_opf) &&
>> - bdev_has_integrity_csum(bio->bi_bdev))) {
>> + (bdev_has_integrity_csum(bio->bi_bdev) ||
>> + bio_has_crypt_ctx(bio)))) {
>
> This could really use a factored helper explaining all the refusals.
> And maybe we should use the chance to sit back and think what else
> would blow up and add it there as well.
>
Hi Christoph, thanks for the review. I will extract a helper in V2 soon.
There are several buffered io fallbacks, it's really necessary to discuss
how to avoid these. Glad to join it.- [RFC 5/6] iomap: refuse dmabuf iterators on contents-enc... Mengmeng Zhao
- Re: [RFC 5/6] iomap: refuse dmabuf iterators on con... Christoph Hellwig
- Re: [RFC 5/6] iomap: refuse dmabuf iterators on... Mengmeng Zhao
- [RFC 4/6] iomap: refuse dmabuf iterators in iomap_file_b... Mengmeng Zhao
- [RFC 6/6] ext4: support dma-buf registered buffers for d... Mengmeng Zhao
- [RFC 2/6] mm/filemap: refuse dmabuf iterators in the gen... Mengmeng Zhao
- Re: [RFC 2/6] mm/filemap: refuse dmabuf iterators i... Christoph Hellwig
- Re: [RFC 2/6] mm/filemap: refuse dmabuf iterato... Mengmeng Zhao
- [RFC 1/6] block: refuse a dma-buf bio that carries a cry... Mengmeng Zhao
- Re: [RFC 1/6] block: refuse a dma-buf bio that carr... Christoph Hellwig
- Re: [RFC 1/6] block: refuse a dma-buf bio that ... Mengmeng Zhao
