Hi Alan,
Just a few comments. The first two are really code nits; the third
is a point I'm not clear on.
Thanks!
renee
nwamadm.c: rather than moving the check of the nwam service state out
to the individual functions where it matters, could you make the
check in main() conditional? That is, have a set of subcmds that
require nwam to be online, and continue to do the state check in
main() if the requested subcmd is in that set.
libnwam.h'57: not sure why this change was needed?
libnwam_loc.c'loc_set_enabled(): It looks like we just enable/disable
as needed while walking the list of locations. What happens if
we hit the to-be-enabled location before other, currently enabled
locations? Does this mean there will be a window where multiple
locations are enabled? What's the consequence of that?
On Wed, Jul 22, 2009 at 01:22:43PM +0100, Alan Maguire wrote:
> probably a lot to review here, but I'm more concerned
> about the design aspects, so if you see anything wrong,
> shout. I'd like to push these today if possible.
>
> http://zhadum.east.sun.com/export/ws/amaguire/nwam1-fixes/webrev/
>
> The main visible changes are:
>
> 9946 <http://defect.opensolaris.org/bz/show_bug.cgi?id=9946> It should be
> possible to change the enable NCP without nwamd running
>
>
> It's now possible to enable/disable objects without nwamd
> running. For ncps, this involves changing the active_ncp
> SMF property via libnwam, for other objects, it involves
> changing their enabled property value.
>
> 10165 <http://defect.opensolaris.org/bz/show_bug.cgi?id=10165> enforce the
> requirement that a max of 1
> <http://defect.opensolaris.org/bz/show_bug.cgi?id=1> location may be active
> at once at the libnwam level
>
>
> Explicitly disable all other enabled=true locations when
> a location is enabled. Only one can be enabled at a time,
> so we enforce this at the library level.
>
> 10168 <http://defect.opensolaris.org/bz/show_bug.cgi?id=10168>
> nwam_wlan_select() should have an additional security mode argument
>
>
> Introduces a security_mode to be specified on WLAN
> selection - this allows hidden WLAN users to specify
> this information. Visible APs can get this data from
> the scan results. nwamadm has been updated accordingly.
>
> 10193 <http://defect.opensolaris.org/bz/show_bug.cgi?id=10193> NCP creation
> should trigger creation of the associated ncp-name.conf file
>
>
> It's now possible to create an empty User NCP and
> have it show up in the list. Destroying the last
> NCU in an NCP no longer removes it.
>
> Thanks!
>
> Alan
> _______________________________________________
> nwam-dev mailing list
> nwam-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/nwam-dev
