I think this is a typo in the door fuction nwamd.  I want to confirm 
that I'm not missing anything.

nwam_*_enable() calls nwam_action() with NWAM_REQUEST_TYPE_*_ACTION.   
This command is then passed to the door function door_switch() in 
nwamd.  door_switch() on the other hand is checking for 
NWAM_EVENT_TYPE_*, which I am guessing is a typo and should be 
NWAM_REQUEST_TYPE_*, right?

Also, there doesn't seem to be "case"s for NCP and LOC and they need to 
be added ....

Then, NCP, LOC, ENM should be finding the correct nwamd_object_t and 
then calling nwamd_*_enable() (and these methods should be non-static).  
Ditto for disabling profile.

Also, if I am not mistaken, only profiles with activation-mode = manual 
are allowed to be enabled/disabled by nwamadm.  nwamd magically takes 
care of the other activation-modes.  Also, what happens (is supposed to 
happen) if a profile whose activation-mode is not manual is disabled by 
nwamadm.

Thanks,
Anurag


Reply via email to