On Wed, Feb 11, 2009 at 04:22:34PM -0500, Anurag S. Maskey wrote:
> I noticed that if no manual location is enabled and if no conditional 
> locations are satisfied, then no locations are activated by nwamd.  So, I 
> added code to enable the Legacy location if there's no winning location.

I think in the case where nothing matches, we should enable the Automatic
location, not the Legacy one.  The only purpose of the Legacy location is
to restore the pre-existing conditions when nwam is disabled.

This is actually buried in the spec; section 4.2.2 says

    This is the default location; i.e. it will be applied when no other
    location has conditions that are met. 

I'm really glad I went to look that up, though; the cited sentence is
followed by an incomplete sentence.  I should probably fix that.  :-)

-renee

> Also, the conditions are rechecked if a manual location is disabled.
>
> http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/
>
> comments include some things that I wondered about ...
>
> Thanks,
> Anurag
>
> _______________________________________________
> nwam-dev mailing list
> nwam-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/nwam-dev

Reply via email to