Michael Hunter wrote:
>> Bug 10116 nwamd core dump while handling SIGTERM
>>
>> Webrev at http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/
>>
>> Signal handling checks to make sure that the phase 1 manifest has been 
>> imported (as discussed in bug report).
>>     
>
> 183-185: You don't know that this SIGHUP came from a refresh as
> discussed in the bug report.
>   
> This is generic signal handeling code.  We could end up here while doing the
> upgrade for example.  By exiting here you could stall forward progress.  If
> this exit() is to just reset our uid/gid then use that as (part of?) the guard
> for the exit.
Good point.  I've added the "uid == 0" test for both if clauses and 
updated the webrev.  (should have had this when the code was in 
refresh() also)

Anurag


Reply via email to