Michael Hunter wrote: > On Fri, 07 Aug 2009 14:54:19 +0100 > Alan Maguire <Alan.Maguire at Sun.COM> wrote: > > >> http://zhadum.east.sun.com/export/ws/amaguire/nwam1-fixes/webrev/ >> >> these changes ensure we pick up legacy WiFi keys >> on upgrade, and make a sensible choice about >> which key we use in the case of multiple essid/bssid >> keys for a given essid. More details in the bug. In >> case you're wondering why I'm fixing a low-priority >> bug (9798), it was addressed by fixing 10205, no extra >> work needed. >> >> Regarding testing, I simulated upgrade by creating >> a known_wifi_nets file and adding multiple keys >> for an ESSID. I reimported the old network-physical >> manifest, and then subsequently imported the new one. >> The upgrade happened, the known_wifi_nets were migrated >> and the keynames set appropriately, with the most recent >> key selected for multiple-match essid/bssid keys. nwamd >> then went on to successfully connect to the WLAN with >> no other intervention needed. >> > > These look good. > > One nit: > known_wlans.c:261-262 why strncmp(x,,strlen(x))? > > The reason is that we're comparing the nwam-<essid> prefix only (which we generate by calling nwamd_set_key_name() with the essid). Legacy keys will have "-<bssid>" as a suffix, so we want to get the last key that matches the essid prefix. Thanks for the review!
Alan > mph > > >> Alan >> _______________________________________________ >> nwam-dev mailing list >> nwam-dev at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/nwam-dev >>
