thanks for the review! Anurag S. Maskey wrote: > minor things below, otherwise all good. > > ncu.c > > 291: empty blank line will fix that, thanks! > 415-424: can be replaced with > nwamd_create_triggered_condition_check_event() > not sure - I wanted to avoid too many condition check events. If a link state changes, then an IP NCU and link NCU are affected, and I wanted to avoid multiple check events. Maybe it'd make sense to modify created_triggered_condition_check_event() to do the "enqueue a check event for a few seconds time if no check event is already enqueued" thing? > ncu_phys.c > > 717-718: "to ensure" twice?? > will fix. thanks again!
Alan
