Hi Anurag, Thanks for taking over on this one!
On Tue, Aug 18, 2009 at 03:22:12PM -0400, Anurag S. Maskey wrote: > code review for 10682 Need a policy / process for handling duplicated > (already used) addresses > http://defect.opensolaris.org/bz/show_bug.cgi?id=10682 > > webrev is at > http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ Just a couple comments: ncu_ip.c, line 681: Do we know at this point that the DELADDR was for a v4 address? Even if that's the case, collisions are possible on v6 interfaces, as well, so we need these checks for both v4 and v6. I'm guessing we probably want to pull the af out of the sockaddr in the event data, rather than always using AF_INET. general question: are there other cases where we put objects into maintenance state? I know we've talked about different cases where that might make sense, but I've never actually seen it happen, so I'm wondering if we've actually implemented that before. In any case, I'm just thinking this is an area we need to test carefully, especially if we're treading new ground with the use of maintenance state here. -renee
