enm.c:549

We should add a "do nothing" for NWAM_STATE_DISABLED when the enm is 
disabled.  Without this we get "enm foo -> state disabled, disabled by 
administrator" with timed condition checks.

==> The "do nothing" for disabled should also be added to manual 
locations that are disabled.

The rest looks good.

Anurag



Alan Maguire wrote:
> code review requested for:
>
> 9830 <http://defect.opensolaris.org/bz/show_bug.cgi?id=9830>  IPv6 
> <http://defect.opensolaris.org/bz/show_bug.cgi?id=6> ncus never come 
> online
> 10654 <http://defect.opensolaris.org/bz/show_bug.cgi?id=10654> 
> Configuring a IPv6 
> <http://defect.opensolaris.org/bz/show_bug.cgi?id=6> static address 
> doesn't work when DHCPv6 
> <http://defect.opensolaris.org/bz/show_bug.cgi?id=6> is available.
> 10805 <http://defect.opensolaris.org/bz/show_bug.cgi?id=10805> 
> destroyed enm generating events
> 10831 <http://defect.opensolaris.org/bz/show_bug.cgi?id=10831> 
> disabling an enm with internal error didn't get 'maintenance' status
>
> For the IPv6 changes, I tested IPv6-only NCUs that
> use:
>
> - static
> - DHCPv6 and static
> - addrconf and static
> - addrconf only
> - DHCPv6 only
>
>
> (Just to clarify, I tested where the router provided
> DHCPv6 addresses and ADDRCONF addresses
> so that we'd get them back and be able to test
> if nwamd picked them up and moved the NCU
> into the right state. It did).
>
> http://zhadum.east/export/ws/amaguire/nwam1-fixes/webrev
>
> Thanks!
>
> Alan
> _______________________________________________
> nwam-dev mailing list
> nwam-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/nwam-dev

Reply via email to