http://defect.opensolaris.org/bz/show_bug.cgi?id=10720



--- Comment #3 from Darren Kenny <dkenny at opensolaris.org> 2009-08-25 
14:16:15 UTC ---
(In reply to comment #2) 
> the issue here is that when we allocate the NEED_KEY event message in nwamd, 
> we
> don't bother filling in these fields. I think selected should be true here of
> course, but I'm not sure we should fill in the rest if the user hasn't made a
> specific BSSID selection, since it's possible different WLANs with the same
> ESSID have different signal strengths, channels, bsstypes etc. Would it be
> acceptable to just fill in the have_key/selected/connected fields here, or do
> you need more? Thanks!

I feel that if we are not "filling in these fields" then they really should
have appropriate values at least, i.e. not random values like (the
speed/signal_strength) or an empty bssid (NULL would be better), etc.

At least this way we can test for things. 

But I suppose, in reality, if it was clearly documented that in the case of the
NEED_KEY event what is expected to be filled in then it would be simpler - or
maybe a suitable flag mechanism to state what fields are valid...? But I'd be
happy enough if the documentation (libnwam.h?) stated what is expected to be
valid.

So, is it correct to say that the only valid field is the essid here?

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

Reply via email to