Anurag S. Maskey wrote:
>
>
> Alan Maguire wrote:
>> ...at
>>
>> http://zhadum.east/export/ws/amaguire/nwam1-fixes/webrev
>
> looks good. minor nits.
>
> ncu.c: Why don't you bzero() the struct and then fill in only the 
> members that are used?
>
will do.
> nwamadm.c: It's amazing that you were able to find this. We need to 
> run tests on both sparc and x86.
>
lucky break I guess - I'd just finished setting up
a sparc lab machine and I hit this.
> libnwam.h: nit really ... I'd prefer the comment to be bulleted or 
> paragraphed so that it is easier to find the different events.
>
sure. Thanks for the review folks!

Alan

Reply via email to