Alan Maguire wrote: > Anurag S. Maskey wrote: >> 9796 [gnome2.26] no check mark beside connected wireless network >> http://defect.opensolaris.org/bz/show_bug.cgi?id=9796 >> >> http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ >> >> The fixes involves >> >> * changing the state to online/up if already connected to a wifi >> network but not online. >> * passing the entire nwam_wlan information to event listeners >> * setting the link "connected" flag for wlan events. >> >> What I am noticing from the GUI in tests is that CONNECTION_REPORT >> and SCAN_REPORT events that are sent before the interface NCU is >> online is ignored. Thus, event after connection is complete the >> check mark does not appear. However, if I force a SCAN_REPORT after >> the interface NCU comes online, then the check mark correctly appears. >> >> As mentioned in the bug comments, the GUI should check the state of >> the link NCU and not the interface NCU. The interface NCU may not be >> in the online state, but the link NCU can and the link NCU shows >> whether the connection has been successful or not. >> > looks good. One question though - shouldn't > we transition the state to online/up around ln1320 > in ncu_phys.c also? (that clause covers the case > where we find the WLAN we're connected to is a > known WLAN and are still connected, so if > we don't we'd still get stuck in the scanning > state if the WLAN is known I think). you're right. added the same check and state change as in the case where the wifi network is not in the known WLAN list.
Anurag
