Hi Alan, On Fri, Sep 18, 2009 at 09:22:24PM +0100, Alan Maguire wrote: > see webrev at: > > http://zhadum.east/export/ws/amaguire/nwam1-fixes/webrev/
Looks good, just one question: in ncu_ip.c'start_dhcp_thread(): at line 1390, you changed a sockaddr_in to a sockaddr_storage; I'm not sure why? We are only dealing with v4 addrs in here. If there is a reason for using a sockaddr_storage, then it seems odd to keep alen = sizeof (struct sockaddr_in) (line 1391). -renee
