The fix for 10453 adds output to stderr when "destroy -a" is done, but these messages are not considered error and thus the return code is still 0 (if everything else goes ok). Most of the interactive nwamcfg tests compare the output and tests fail because the message from "destroy -a" is not expected. The tests should ignore these messages.
libnwam.h has changed with the addition of new function calls. No existing function or constants were modified. The webrev for this push is at http://zhadum.eastexport/ws/am223141/checkout-area/nwam1-fixes/webrev.nwamcfg-code-review/ Thanks, Anurag Anurag.Maskey at Sun.COM wrote: > Author: Anurag S. Maskey <Anurag.Maskey at Sun.COM> > Repository: /hg/nwam/nwam1 > Latest revision: 160fd9d6e088efecba6d187841c0166e9d4bd450 > Total changesets: 1 > Log message: > nwamcfg code review comments: meem-109...180 > 11385 Got error while setting 'activation-mode'. > 10453 nwamcfg destroy -a silently fails to destroy the User ncp if it was > previously active > > Files: > create: usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/nwamcfg.xcl > update: usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/Makefile > update: usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/nwamcfg.c > update: usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/nwamcfg.h > update: usr/src/cmd/cmd-inet/usr.sbin/nwamcfg/nwamcfg_grammar.y > update: usr/src/lib/libnwam/common/libnwam.h > update: usr/src/lib/libnwam/common/libnwam_enm.c > update: usr/src/lib/libnwam/common/libnwam_files.c > update: usr/src/lib/libnwam/common/libnwam_impl.h > update: usr/src/lib/libnwam/common/libnwam_known_wlan.c > update: usr/src/lib/libnwam/common/libnwam_loc.c > update: usr/src/lib/libnwam/common/libnwam_ncp.c > update: usr/src/lib/libnwam/common/libnwam_object.c > update: usr/src/lib/libnwam/common/mapfile-vers > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev >
