Michael Hunter wrote: > On Tue, 29 Sep 2009 11:30:11 -0400 > "Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote: > > >> requesting code review for bug 11566 when static addresses are used in >> the User NCP, the Automatic location does not go online immediately >> (http://defect.opensolaris.org/bz/show_bug.cgi?id=11546) >> >> >> http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/ >> > > There is an existing race condition. The alarm needs to be set under > the lock otherwise there could be a race. > > You could make the logic a little more straightforward by just getting > the first thing off the list and setting the alarm to the delta to that. > gotcha. After the timed event is enqueued, the alarm is set to remaining time of the first event in the timed event queue.
webrev updated. Anurag
