On Thu, 01 Oct 2009 16:04:07 -0700 Renee Danson Sommerfeld <renee.sommerfeld at sun.com> wrote:
> I have a webrev up for the current fix for > > http://defect.opensolaris.org/bz/show_bug.cgi?id=11614 > > Webrev is > > http://jurassic.eng/~okie/rename-webrev/index.html > > Please let me know what you think! libnwam_backend.c:257 strlen(req->nwbda_object) > 0 ? req->nwbda_object : NULL is equivalent to req->nwbda_object[0] == 0 ? NULL : req->nwbda_object You don't really care how much longer, just that it contains at least one character. libnwam_object.c:138-139 why not just strcpy()? You are not going to wear out the memory any faster not walking it twice. Both nits. The first one is really outside of (although close to) your changeset. Assuming you just fix lint errors do with these as you wish and push when you feel comfortable. mph > > Thanks, > renee > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev
