Michael Hunter wrote: > On Wed, 07 Oct 2009 11:13:28 -0400 > "Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote: > > >> code review request for >> 11784 sometimes periodic events don't happen >> http://defect.opensolaris.org/bz/show_bug.cgi?id=11784 >> >> >> http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/ >> > > Get rid of the local and you won't have to worry about the sign issues. > You mean rather than doing rather than calculating "nextalarm", just using "e->event_time" and "now"? > I dislike that we sometimes push timers forward a second when they > should expire within the second and other times have events which have > a 0 delta we let run out. But I can't really think of why it would > really matter. Probably worth explaining in a comment as it is not > intuitive at least to me :) > If the alarm should go off in this second, then it has already been set (http://defect.opensolaris.org/bz/show_bug.cgi?id=11784#c5). The granularity is seconds. Maybe I'm not understanding your comment ...
Anurag
