On Thu, 08 Oct 2009 07:49:50 +0100 Alan Maguire <Alan.Maguire at Sun.COM> wrote:
> Michael Hunter wrote: > > On Wed, 07 Oct 2009 21:21:14 +0100 > > Alan Maguire <Alan.Maguire at Sun.COM> wrote: > > > > > >> webrev at: > >> > >> http://zhadum.east/export/ws/amaguire/nwam1-cr/webrev > >> > >> the fix involved > >> > >> 1) ensuring that we set the selected WLAN in the > >> scan results when we make a selection > >> 2) update the nwamadm show-events output to > >> show if the WLANs in the scan results are selected > >> or connected > >> > > > > The first part of this fix is what I gave to Darren. Hopefully the > > second part is what he needs. > > > > > Seems like it did the trick - I just heard back > from him and it seems to work. > > I don't believe checking the first byte of the bssid is enough. > > > > > Can you elaborate here? I'm not sure I understand. > The change I made here was to ensure that we support > ESSID-only selection, which is what the GUI does. By > only matching to BSSID if a BSSID is set in > nwamd_wlan_selected_connected(), we ensure we > mark all valid selections (and libnwam sets the first > byte in the BSSID string to '/0' for requests where the > BSSID argument is NULL). I misread this code. I thought you were looking at the raw bytes of the bssid. Code looks good. I'm glad it works. mph > Thanks! > > Alan
