On Fri, Oct 16, 2009 at 03:52:21PM -0400, Anurag S. Maskey wrote: > >>>>> 11927 - walkprop shows properties that should be skipped >>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=11927 >>>>> >>>>> >>>>> http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ >>>> This one makes me a little nervous, given that it's fairly complicated >>>> logic and recursion is now in the picture. Are we certain that there >>>> are clear stopping points for the recursion? >> >> I've been thinking more about this recursion in detail. The way it >> currently is, the recursion relies that there are no circular >> dependencies in the rules table. If there is a circular dependency by >> mistake (I can't think of an actual example), then the recursion has a >> problem. I'm gonna have to include code that checks for this >> circularity and if detected, stops the recursion. > > To solve this circular dependency, I added an argument to > show_prop_test() that is called with the property that has just been > tested. If this property is passed to show_prop_test() again later, > then there is a circular dependency and show_prop_test() returns B_FALSE > so that the initial prop is not displayed. > > I've updated the webrev with this addition.
Okay, thanks for revisiting; your changes look reasonable. -renee
