Alan Maguire wrote: > Anurag S. Maskey wrote: >> webrev at >> >> >> http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/ >> >> for >> >> 12107 invalid fmri should take enm to maintenance state on >> disable >> http://defect.opensolaris.org/bz/show_bug.cgi?id=12107 >> > > enm.c: ln574 - I don't think we want to be doing > nwamd_object_set_state() for objects that are being > destroyed since that confuses the GUI. In the process > of destroying ENMs, we go from online*/uninitialized > to uninitialized/uninitialized so we'll send out an unneeded > state change. Adding an "if (!destroying)" clause to the start > of the predicate here will filter that case out. Otherwise looks > perfect.
you're right. I was thinking about this, but forgot when I changed the code. I also added the !destroying to line 521 (along with 574 that you mentioned). webrev has been updated. Anurag
