Michael Hunter wrote: > On Tue, 20 Oct 2009 11:02:19 -0400 > "Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote: > > >> Michael Hunter wrote: >> >>> Please look at /net/coupe.eng/builds/mph/nwam1_work/webrev for: >>> >>> 11865 upgrade needs to cope with existing NIS configurations >>> 11978 nwamd exiting due to an assertion >>> 12025 core: wifi thread and destruction of object warring >>> >>> >> net-loc: I don't now if sed is able to use to the $USER_LOC_PATH and >> other variables. If yes, it would be good to use these. >> > > I don't see where I missed these. We don't have a path for the > temporary scripts we create. I've added those. Point me at any others > I've missed when I put this out again. > I meant using $USER_LOC_PATH instead of /etc/user/loc/User in the sed scripts. Just a nit.
>> net-loc:599-603 Hate to add another complexity to the User location, but >> "ipfilter-config-file" is hacked to achieve two different things. Its >> commented in net-nwam:267-270. If firewall_config_default/policy >> property of ipfilter is set to "none", "allow", or "deny", >> ipfilter-config-file saves this value as /none, /allow, or /deny >> respectively (The / is necessary because the property expects an >> absolute path). If the policy property is "custom", then >> ipfilter-config-file has the path to file (just like the other >> *-config-file) properties. There is no need to append to the >> copy_user_files script if /none, /allow or /deny exist. Maybe: >> $GREP "ipfilter-config-file" >> /etc/svc/volatile/nwam/create_loc_legacy | \ >> $GREP -v "/none" | $GREP -v "/deny" | $GREP -v "/allow" | \ >> $SED .... >> couldn't figure out a way to collapsed the "grep -v"s. >> > > $GREP -vE "/none|/deny|/allow" > > I'll discuss the rest of this in response to Renee's comment. > /usr/bin/grep doesn't have the -E flag, /usr/xpg4/bin/grep does. > >> net-loc:654-655 We still need the addpg line now that we moved to two >> different property groups. property group "location" may not exist. >> > > I put them both before this block of code. > The addpg of location_upgrade is not necessary after the first run of net-loc. might be better to move it to right before the version property is set. Your call. Anurag
