Michael Hunter wrote:
> On Thu, 22 Oct 2009 16:02:14 -0400
> "Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote:
>
>   
>> 11926 Legacy location with NIS hostnames fails
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=11926
>>
>> http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/
>>
>> Verifies that the addresses in ypservers are v4 or v6.  If not, its 
>> assumed to be hostname and is grep'ed in /etc/inet/hosts.  I moved these 
>> utility-like functions to net_include.sh.
>>     
>
> is_valid_v4addr: Use an RE to check validity.  I googled and got buried
> in them.
>
> is_valid_v6addr: check that there is at most one :: (see RFC 2373).
> These REs are gross but again google finds them.
>   
I agree that the :: test was missing.  The nwak loops are much easier to 
understand.

In any case, since I already spent a day slaving through regular 
expressions, I've updated the webrev with those.   Hopefully, I got all 
cases.  Let me know if I missed some ip address. I added comments to 
express what I was trying to match.

Anurag

>               Michael
>
>   
>> Thanks,
>> Anurag
>> _______________________________________________
>> nwam-dev mailing list
>> nwam-dev at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/nwam-dev
>>     

Reply via email to