Hi Alan,
On Tue, Nov 10, 2009 at 02:29:42PM +0000, Alan Maguire wrote:
> webrev at:
>
> http://zhadum.east.sun.com/export/ws/amaguire/nwam1-bugs/webrev/
Just a few comments:
nit: one of the bugids in the comment is wrong-- s/12856/12586/
ncp.c
79-81: the mention of the NCU state events triggered by the NCU
fini events worries me: won't it be the case that we get
fini events, then NCP state event (all enqueued here),
then NCU state events (enqueued when the fini events are
processed)? Seems like things are still out of order.
On the other hand, you mention in the bug report that the
fini events create and directly process state changes, so
that would mean we would *not* end up with the state events
enqueued after the NCP state event. Assuming that's the
case, you should probably clarify that in this comment.
ncu.c
1239: Do we need to do the ncu check on remove of a link, as well?
1720-1753: Looks like you don't have Anurag's changes for 12479
in here; be sure to sync and reci before pushing.
-renee
