On Fri, Dec 04, 2009 at 01:52:28PM -0500, Anurag S. Maskey wrote: > Found bug 13084 during testing of nwam1_128a. > http://defect.opensolaris.org/bz/show_bug.cgi?id=13084 > > code review greatly appreciated. > http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/
Just one suggestion: A more specific identifier name would be good; maybe 'readfail' instead of 'fail'? I think that would make reading the code easier, especially given that you can 'goto done' in failure cases as well. Otherwise, looks good. -renee
