On Wed, Dec 16, 2009 at 09:45:16AM -0500, Anurag S. Maskey wrote: > code review requested for: > > 13382 list in object scope should only take the -a argument > http://defect.opensolaris.org/bz/show_bug.cgi?id=13382 > > http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/
Your changes look fine. But I'd like to work on the error text on lines 3030-31 and 3058. When I saw the latter message in the bug report, I was pretty confused by it; I read it as "this is the only scope that allows the -a option," which isn't what we mean there. So for the first message (at lines 3030-31), maybe something like "'list' requires an object to be specified with the -a option in the global scope"? And for the second: "Additional options are not allowed with the -a option at this scope." I'm not in love with either of those; feel free to tweak. But I do think they convey the problem a little more clearly than the current messages. -renee
