>>>>>> http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/ >>>>>> >>>>>> 13416 "dhcp,static" ipv4 address not working >>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=13416 >>>>>> >> I've reworked the fix. The interface name with lifnum is kept track in >> the nwamd_if_address structure. Previously, only static addresses had >> this structure, but I've added flags to denote if the structure is for a >> DHCP address and the ifnames are stored there. When a FREEADDR/DELADDR >> is received, the ifname is determined from that structure. >> > > ncu.c:828,830 (sim'ly 919/921,929,931) (style) Just use *nifa instead of > introducing tmp? > ACCEPT. also fixed similar existing code that wasn't part of this bugfix. > ncu.h:118,119 What is the difference between dhcp_if and stateful_if? > stateful_if was the flag to say dhcpv6 was requested. I've removed this flag and use the dhcp_if flag for both v4 and v6 dhcp. v6 autoconf flags remains stateless_if. > ncu_ip.c:471 Please put a block comment on this function. Feels more > like find_assigned_address or find_nonstatic_address. Mixing v4 and v6 > with the flag only applying to v6 makes this function a bit odd. In > any case if you can explain it in a block comment that is good enough. > I called it find_nonstatic_address() and also added the comment. webrev updated.
> ncu_ip.c:481 else if, these are exclusive > ACCEPT > ncu_ip.c:1013,1032 Even if we get to 1013 isn't 1032 still going to fail? > No. line 1013 has found the ifname with lifnum and then 1032 gets the flags for that interface. any reason it would fail? > >> I did not do anything with the failures yet. It is a separate issue and >> I don't want to deal with it here. >> > > Separate that out into a separate RFE. I've written that code before > and will do it again if it proves worthwhile. > I did. It's bug 13706 http://defect.opensolaris.org/bz/show_bug.cgi?id=13706 Anurag
