On Mon, Feb 22, 2010 at 07:41:33PM +0000, Alan Maguire wrote: > I think I have a fix for this. The problem was we > were unconditionally enabling network/location > which confuses manifest-import. The fix is > to check if network/location exists before enabling, > see > > http://zhadum.east.sun.com/export/ws/amaguire/nwam1-fix/webrev/
These changes look reasonable. One thing I noticed: could you fix the typo on line 732 in net_include.sh (just after the bit you added)? s/temporarirly/temporarily/ One concern, though. We're using /usr/bin/svcs, which is not guaranteed to be present the first time net-nwam runs (the nwam service does not-- and cannot--depend on filesystem/usr). I'm pretty sure this is not the only place where this assumption is made (it was made in the check we just removed, in fact); and the net-nwam script is likely not the only one that does this. And it is--at least as far as I know--primarily an academic concern, as folks don't generally separate root and usr. But this seems like an issue for the smf utilities in particular, which are in /usr/bin and are really handy when one is starting up a service. Do you know if there's any general solution for this? Work in progress, by any chance? -renee > I need to retest, should have confirmation this > works in a few hours... > > Alan > > On 22/02/2010 17:19, Alan Maguire wrote: > >I saw this myself today after fresh install/bfu. > >I've sent mail to smf-discuss to see if there's > >any explanation/similar bugs. I wonder if it has > >to do with the tmpfs dance that's done during > >manifest-import? I noticed on my system that > >network/location was the last manifest to > >be imported, that might be significant, not sure. > >It's clearly not an issue with the network/location > >manifest itself, as if we "svccfg delete -f location" > >and reimport, all is well. > > > >Alan > > > >On 17/02/2010 18:16, Anurag S. Maskey wrote: > >>Anyone else notice the following in sparc: > >> > >>After BFU and reboot, there are no locations, but > >>network/location is online. > >> > >> > >>bash-4.0# nwamcfg list > >>NCPs: > >> Automatic > >> User > >> > >>Doing a restart or refresh doesn't change anything at all. > >> > >>I checked the properties for network/location and noticed that a > >>lot of the normal properties (like start, stop, etc) are > >>missing. > >> > >>bash-4.0# svcprop location > >>location_netcfg/entities fmri svc:/network/netcfg > >>location_netcfg/external boolean true > >>location_netcfg/grouping astring require_all > >>location_netcfg/restart_on astring none > >>location_netcfg/type astring service > >>general/enabled boolean false > >>manifestfiles/var_svc_manifest_network_network-location_xml > >>astring /var/svc/manifest/network/network-location.xml > >>restarter_actions/auxiliary_tty boolean false > >>restarter_actions/auxiliary_fmri astring svc:/network/physical:nwam > >>restarter_actions/refresh integer > >>restarter/auxiliary_state astring none > >>restarter/logfile astring /var/svc/log/network-location:default.log > >>restarter/next_state astring none > >>restarter/state astring online > >>restarter/state_timestamp time 1266427310.165508000 > >>general_ovr/enabled boolean true > >> > >>manifest-import did not have any warnings, but I decided to > >>import the manifest anyways (the manifest is correct). > >> > >>bash-4.0# svccfg import /var/svc/manifest/network/network-location.xml > >>bash-4.0# > >>bash-4.0# svcadm refresh location > >>bash-4.0# svcprop location > >>location_netcfg/entities fmri svc:/network/netcfg > >>location_netcfg/external boolean true > >>location_netcfg/grouping astring require_all > >>location_netcfg/restart_on astring none > >>location_netcfg/type astring service > >>general/enabled boolean false > >>manifestfiles/var_svc_manifest_network_network-location_xml > >>astring /var/svc/manifest/network/network-location.xml > >>restarter_actions/auxiliary_tty boolean true > >>restarter_actions/auxiliary_fmri astring > >>svc:/system/console-login:default > >>restarter_actions/refresh integer > >>restarter/auxiliary_state astring none > >>restarter/logfile astring /var/svc/log/network-location:default.log > >>restarter/next_state astring none > >>restarter/state astring online > >>restarter/state_timestamp time 1266429258.810348000 > >>general_ovr/enabled boolean true > >> > >>still the properties are messed up. > >> > >>x86 did not exhibit this problem. I already bfu'ed twice on > >>sparc, made sure acr was done. > >> > >>Anurag > >> > >>_______________________________________________ > >>nwam-dev mailing list > >>nwam-dev at opensolaris.org > >>http://mail.opensolaris.org/mailman/listinfo/nwam-dev > > > >_______________________________________________ > >nwam-dev mailing list > >nwam-dev at opensolaris.org > >http://mail.opensolaris.org/mailman/listinfo/nwam-dev > > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev
