http://defect.opensolaris.org/bz/show_bug.cgi?id=14763
Renee Danson Sommerfeld <renee.danson at sun.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |renee.danson at sun.com
--- Comment #2 from Renee Danson Sommerfeld <renee.danson at sun.com>
2010-02-23 17:08:34 UTC ---
(In reply to comment #1)
> (In reply to comment #0)
> > strstr() retuns NULL if a match is not found. The check in check_wlan()
> > should
> > look for NULL, not 0.
>
> I havn't looked at the code but by the language specification in a pointer
> context 0 is equivalent to NULL. So this isn't a bug in that case. But I
> think it makes the code read more expected which is a good thing.
It is true that the strstr() comparing to 0 was not the bug; the bug was that
the "contains" and "does not contain" condition checks were reversed. Anurag's
fix covers both the actual bug and the coding style issue.
--
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
