On Tue, Mar 16, 2010 at 03:57:51PM -0400, Anurag S. Maskey wrote: > > CR 6935387 nwamd core dumps in nwamd_deescalate() > > http://zhadum.east/export/ws/am223141/checkout-area/onnv-bug-6935387/webrev/
Your changes look good. The only nit I would have is that you could move the declaration for priv_set and allpriv_set (on line 110) into the 'if (--uid_cnt == 0)' block; but it's really up to you. > nwamd_deescalate() was calling priv_freeset() when the priv_set_t > wasn't set. Fix involves moving the priv_freeset() calls up, only > when priv_str_to_set() is called. > > I think this bug qualifies as a stopper. nwam doesn't run at all. > Although I did find that sometimes, (with multiple restarts) nwamd > doesn't dump core and nwam comes online. I think this fix should be > pulled into a 136 respin. Seems that way to me. Thanks for the catch and the quick fix. -renee
