On Wed, 24 Mar 2010 08:52:47 -0400
"Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote:

> 
> > enm.c:225-227 What is wrong with gettimeofday(&object->nwamd_script_time, 
> > NULL) or
> >     object->nwamd_script_time = now?
> >   
> went with the second one.  "now" is necessary to compare the timestamp 
> from the object after the script finishes.
> > When you clean you might also think about setting to the time you clear 
> > instead of 0.
> > OTOH if you always set to 0 when you clean then you only need to store 
> > seconds or some
> > other free running (e.g. high resolution timers) timer.  I kind of like 
> > storing the
> > sec/usec on clear as that might have some debugging value.
> >   
> I changed both setting of 0 to gettimeofday().
> 
> webrev updated.

Looks great.  Push.

        Michael

> 
> Anurag
> 
> _______________________________________________
> nwam-dev mailing list
> nwam-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/nwam-dev

Reply via email to