Hey Nico, No problems from CSU, we have focused on only making configurations where possible rather than customisations, so it should not affect us much if at all.
Thanks ;) Dave -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Nicolaas Matthijs Sent: Wednesday, 11 July 2012 5:26 PM To: OAE Production; oae-dev [email protected] Subject: [oae-dev] Code styling issues Hi everyone, At last week's UI dev call, we discussed doing a full sweep over the entire codebase, cleaning up all places that do not adhere to our style guide (spacing issues, double quotes instead of single quotes, CSS not expanded, etc.). In the last weeks, various pull requests have been re-opened and slowed down because of the styling issues they had, and therefore we'd like to do one focussed pass and then continue with a commit hook and unit tests that checks for violations of the style guide. However, before we go ahead, I wanted to check whether the institutions running Sakai OAE in production are fine with this, as there will be an increased likelihood of merge conflicts in areas where custom code is present. The potential merge conflicts should be fairly easy to resolve, but we still wanted to check first. Any objections? Thanks, Nicolaas _______________________________________________ oae-dev mailing list [email protected] http://collab.sakaiproject.org/mailman/listinfo/oae-dev Charles Sturt University | ALBURY-WODONGA | BATHURST | CANBERRA | DUBBO | GOULBURN | MELBOURNE | ONTARIO | ORANGE | PORT MACQUARIE | SYDNEY | WAGGA WAGGA | LEGAL NOTICE This email (and any attachment) is confidential and is intended for the use of the addressee(s) only. If you are not the intended recipient of this email, you must not copy, distribute, take any action in reliance on it or disclose it to anyone. Any confidentiality is not waived or lost by reason of mistaken delivery. Email should be checked for viruses and defects before opening. Charles Sturt University (CSU) does not accept liability for viruses or any consequence which arise as a result of this email transmission. Email communications with CSU may be subject to automated email filtering, which could result in the delay or deletion of a legitimate email before it is read at CSU. The views expressed in this email are not necessarily those of CSU. Charles Sturt University in Australia http://www.csu.edu.au The Chancellery, Panorama Avenue, Bathurst NSW Australia 2795 ABN: 83 878 708 551; CRICOS Provider Numbers: 00005F (NSW), 01947G (VIC), 02960B (ACT) Charles Sturt University in Ontario http://www.charlessturt.ca 860 Harrington Court, Burlington Ontario Canada L7N 3N4 Registration: www.peqab.ca Consider the environment before printing this email. _______________________________________________ oae-dev mailing list [email protected] http://collab.sakaiproject.org/mailman/listinfo/oae-dev
