Author: mduerig
Date: Wed Jan 29 09:17:32 2014
New Revision: 1562382
URL: http://svn.apache.org/r1562382
Log:
OAK-1332: Large number of changes to the same node can fill observation queue
Fix Javadoc, make private help static
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/UniversalFilter.java
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/VisibleFilter.java
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/handler/ChangeHandler.java
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/UniversalFilter.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/UniversalFilter.java?rev=1562382&r1=1562381&r2=1562382&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/UniversalFilter.java
(original)
+++
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/UniversalFilter.java
Wed Jan 29 09:17:32 2014
@@ -70,9 +70,9 @@ public class UniversalFilter implements
* Map a property event.
* @param filter filter instance on which respective call back
occurred.
* @param before before state or {@code null} for
- * {@link EventFilter#propertyAdded(PropertyState)}
+ * {@link EventFilter#includeAdd(PropertyState)}
* @param after after state or {@code null} for
- * {@link EventFilter#propertyDeleted(PropertyState)}
+ * {@link EventFilter#includeDelete(PropertyState)}
* @return a {@code NodeState} instance for basing the filtering
criterion (predicate) upon
*/
@Nonnull
@@ -84,9 +84,9 @@ public class UniversalFilter implements
* @param filter filter instance on which respective call back
occurred.
* @param name name of the child node state
* @param before before state or {@code null} for
- * {@link EventFilter#childNodeAdded(String, NodeState)}
+ * {@link EventFilter#includeAdd(String, NodeState)}
* @param after after state or {@code null} for
- * {@link EventFilter#childNodeDeleted(String,
NodeState)}
+ * {@link EventFilter#includeDelete(String, NodeState)}
* @return a NodeState instance for basing the filtering criterion
(predicate) upon
*/
@Nonnull
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/VisibleFilter.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/VisibleFilter.java?rev=1562382&r1=1562381&r2=1562382&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/VisibleFilter.java
(original)
+++
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/filter/VisibleFilter.java
Wed Jan 29 09:17:32 2014
@@ -28,7 +28,7 @@ import org.apache.jackrabbit.oak.spi.sta
*/
public class VisibleFilter implements EventFilter {
- private boolean isVisible(String name) {
+ private static boolean isVisible(String name) {
return !name.startsWith(":");
}
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/handler/ChangeHandler.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/handler/ChangeHandler.java?rev=1562382&r1=1562381&r2=1562382&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/handler/ChangeHandler.java
(original)
+++
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/handler/ChangeHandler.java
Wed Jan 29 09:17:32 2014
@@ -98,7 +98,7 @@ public interface ChangeHandler {
* Notification for a reordered node
* @param destName name of the {@code orderBefore()} destination node
* @param name name of the moved node
- * @param moved moved node
+ * @param reordered moved node
*/
void nodeReordered(String destName, String name, NodeState reordered);
