Author: angela
Date: Thu Feb 20 14:19:30 2014
New Revision: 1570202
URL: http://svn.apache.org/r1570202
Log:
cleanup TODOs
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/PermissionValidator.java
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/PermissionValidator.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/PermissionValidator.java?rev=1570202&r1=1570201&r2=1570202&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/PermissionValidator.java
(original)
+++
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/PermissionValidator.java
Thu Feb 20 14:19:30 2014
@@ -320,7 +320,9 @@ class PermissionValidator extends Defaul
}
private boolean isImmutableProperty(String name) {
- // TODO: review; cant' rely on autocreated/protected definition as
this doesn't reveal if a given property is expected to be never modified after
creation
+ // NOTE: we cannot rely on autocreated/protected definition as this
+ // doesn't reveal if a given property is expected to be never modified
+ // after creation.
if (JcrConstants.JCR_UUID.equals(name) &&
isReferenceable.apply(parentAfter.getNodeState())) {
return true;
} else if ((JCR_CREATED.equals(name) || JCR_CREATEDBY.equals(name))