svn commit: r1689422 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/CompactionGainEstimate.java

[mduerig]

Author: mduerig
Date: Mon Jul  6 15:04:09 2015
New Revision: 1689422

URL: http://svn.apache.org/r1689422
Log:
OAK-3075: Compaction Estimation should type check binary properties
Clarifying comment

Modified:
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/CompactionGainEstimate.java

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/CompactionGainEstimate.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/CompactionGainEstimate.java?rev=1689422&r1=1689421&r2=1689422&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/CompactionGainEstimate.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/CompactionGainEstimate.java
 Mon Jul  6 15:04:09 2015
@@ -62,6 +62,11 @@ class CompactionGainEstimate implements
                     collectUUID(((SegmentPropertyState) property)
                             .getRecordId().getSegmentId());
                 }
+
+                // Get the underlying value as stream so we can collect
+                // the segments ids involved in storing the value.
+                // This works as primitives are stored as strings and strings
+                // as binaries of their UTF-8 encoding.
                 for (Blob blob : property.getValue(BINARIES)) {
                     for (SegmentId id : SegmentBlob.getBulkSegmentIds(blob)) {
                         collectUUID(id);