svn commit: r1717381 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/MetricStatisticsProvider.java

[chetanm]

Author: chetanm
Date: Tue Dec  1 06:24:06 2015
New Revision: 1717381

URL: http://svn.apache.org/viewvc?rev=1717381&view=rev
Log:
OAK-3654 - Integrate with Metrics for various stats collection

Disable metric for session read counter also as its very critical and having 
metric stats there would not be of much use. Compared to that Write counter is 
more important so there metrics would be enabled

Modified:
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/MetricStatisticsProvider.java

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/MetricStatisticsProvider.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/MetricStatisticsProvider.java?rev=1717381&r1=1717380&r2=1717381&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/MetricStatisticsProvider.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/MetricStatisticsProvider.java
 Tue Dec  1 06:24:06 2015
@@ -58,9 +58,11 @@ public class MetricStatisticsProvider im
     private static final String JMX_TYPE_METRICS = "Metrics";
 
     /**
-     * Types for which Noop Variant has to be used
+     * Types for which Metrics based stats would not be collected
+     * and only default stats would be collected
      */
-    private static final Set<String> NOOPS_TYPES = ImmutableSet.of(
+    private static final Set<String> NOOP_METRIC_TYPES = ImmutableSet.of(
+            Type.SESSION_READ_COUNTER.name(),
             Type.SESSION_READ_DURATION.name(),
             Type.SESSION_WRITE_DURATION.name(),
             Type.QUERY_COUNT.name()
@@ -141,7 +143,7 @@ public class MetricStatisticsProvider im
                 delegate = new SimpleStats(repoStats.getCounter(type, 
resetValueEachSecond));
             }
 
-            if (NOOPS_TYPES.contains(name)) {
+            if (NOOP_METRIC_TYPES.contains(name)) {
                 stats = delegate;
             } else {
                 stats = builder.newComposite(delegate, this, name);