svn commit: r1747637 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/plugins/document/Range.java test/java/org/apache/jackrabbit/oak/plugins/document/RangeTest.java

[chetanm]

Author: chetanm
Date: Fri Jun 10 05:28:35 2016
New Revision: 1747637

URL: http://svn.apache.org/viewvc?rev=1747637&view=rev
Log:
OAK-4457 - Range constructor should use parametrized assertion message

Modified:
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/Range.java
    
jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/RangeTest.java

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/Range.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/Range.java?rev=1747637&r1=1747636&r2=1747637&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/Range.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/Range.java
 Fri Jun 10 05:28:35 2016
@@ -43,7 +43,7 @@ final class Range {
         checkArgument(high.getClusterId() == low.getClusterId(),
                 "Revisions from have the same clusterId");
         checkArgument(high.compareRevisionTime(low) >= 0,
-                "High Revision must be later than low Revision, high=" + high 
+ " low=" + low);
+                "High Revision must be later than low Revision, high=%s 
low=%s" ,high, low);
         checkArgument(height >= 0);
     }
 

Modified: 
jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/RangeTest.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/RangeTest.java?rev=1747637&r1=1747636&r2=1747637&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/RangeTest.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/RangeTest.java
 Fri Jun 10 05:28:35 2016
@@ -55,4 +55,13 @@ public class RangeTest {
         assertEquals("r1-0-1/0", r.getLowValue());
         assertEquals(r, Range.fromEntry(high, r.getLowValue()));
     }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void invalidRange() throws Exception{
+        Revision low = new Revision(0x100, 0, 1);
+        Revision high = new Revision(0x300, 0, 1);
+
+        Range range = new Range(low, high, 0);
+
+    }
 }